Skip to content

Commit 568fd97

Browse files
authored
Merge pull request #234 from xdev-software/develop
Release
2 parents 98f9ea5 + be2e69d commit 568fd97

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
# 1.5.1
2+
* Slightly increased default recording save wait time a bit
3+
14
# 1.5.0
25
* No longer map timezone into container by default
36
* This should keep tests consistent

testcontainers-selenium/src/main/java/software/xdev/testcontainers/selenium/containers/browser/BrowserWebDriverContainer.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ public class BrowserWebDriverContainer<SELF extends BrowserWebDriverContainer<SE
9494

9595
protected static Boolean currentOsWindows; // You should use the method instead, this might be NULL
9696

97-
protected boolean mapTimezoneIntoContainer = false;
97+
protected boolean mapTimezoneIntoContainer;
9898

9999
protected boolean validateImageEnabled = true;
100100
protected Duration validateImageGetTimeout = Duration.ofMinutes(5);
@@ -114,8 +114,8 @@ public class BrowserWebDriverContainer<SELF extends BrowserWebDriverContainer<SE
114114
protected Path recordingDirectory;
115115
protected TestRecordingFileNameFactory testRecordingFileNameFactory = new DefaultTestRecordingFileNameFactory();
116116
protected Duration recordingSaveTimeout = Duration.ofMinutes(3);
117-
// Ensure that the current frame will be fully recorded (default record FPS = 15 -> 67ms per Frame)
118-
protected Duration beforeRecordingSaveWaitTime = Duration.ofMillis(70);
117+
// Ensure that the current frame will be fully recorded (default record FPS = 15 -> 67ms per Frame + some buffer)
118+
protected Duration beforeRecordingSaveWaitTime = Duration.ofMillis(100);
119119

120120
public BrowserWebDriverContainer(final String dockerImageName)
121121
{

0 commit comments

Comments
 (0)