Skip to content

openssl: skip patch Configurations when version <= 1.1.0 (#8282) #8390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2025
Merged

openssl: skip patch Configurations when version <= 1.1.0 (#8282) #8390

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/o/openssl/configure/patch.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
function _fix_overlong_make_recipe(package)
-- Skip when OpenSSL version <= 1.1.0 as they don't have the `Configurations` directory
-- see: https://github.com/xmake-io/xmake-repo/issues/8282
if package:version():le("1.1.0") then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The version check le("1.1.0") (less than or equal to) appears to be incorrect. The Configurations directory, which this patch targets, was introduced in OpenSSL 1.1.0. Therefore, the patch should be applied to version 1.1.0 and later. The current logic le would incorrectly skip the patch for version 1.1.0 itself.

The condition should check for versions less than 1.1.0. Using lt("1.1.0") would be correct.

This logic seems to be copied from other functions in this file (_remove_unused_pod_usage and _replace_NUL_with_null), so this correction should likely be applied there as well for consistency and correctness.

    if package:version():lt("1.1.0") then

return
end
-- In the MSYS environment, the make recipe can be too long to execute.
-- This patch is adapted from OpenSSL 3.
-- For more details, see: https://github.com/openssl/openssl/issues/12116
Expand Down
Loading