Skip to content

Commit 8e2dc77

Browse files
committed
JIRA-74: Handle the possibility to pass a JQL instead of a filter ID in BiDimensionalGridChart
* Support JQL query using filterID=jql-<query> format in REST API.
1 parent a4a8d6f commit 8e2dc77

File tree

2 files changed

+20
-2
lines changed

2 files changed

+20
-2
lines changed

jira-macro/jira-macro-charts/src/main/java/org/xwiki/contrib/jira/charts/internal/AbstractJIRAChartDataFetcher.java

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ public U fetch(T parameters, Class<U> expectedType) throws MacroExecutionExcepti
6666
if (!StringUtils.isEmpty(parameters.getFilterId())) {
6767
parametersList.add(handleFilterIdParameter(parameters.getFilterId()));
6868
} else {
69-
parametersList.add(new BasicNameValuePair("jql", parameters.getQuery()));
69+
parametersList.add(handleQueryParameter(parameters.getQuery()));
7070
}
7171
parametersList.addAll(getCustomQueryParameters(parameters));
7272

@@ -110,6 +110,16 @@ public NameValuePair handleFilterIdParameter(String filterIdValue)
110110
return new BasicNameValuePair("filterId", computeFilterIdFormat(filterIdValue, false));
111111
}
112112

113+
/**
114+
* Define how to handle the query parameter.
115+
* @param queryValue the value given by the user
116+
* @return the {@link NameValuePair} used to perform the REST call.
117+
*/
118+
public NameValuePair handleQueryParameter(String queryValue)
119+
{
120+
return new BasicNameValuePair("jql", queryValue);
121+
}
122+
113123
/**
114124
* @return the type of requested gadget.
115125
*/

jira-macro/jira-macro-charts/src/main/java/org/xwiki/contrib/jira/charts/internal/bidimensionalgrid/JIRABiDimensionalGridChartDataFetcher.java

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,8 @@ public class JIRABiDimensionalGridChartDataFetcher
4444
extends AbstractJIRAChartDataFetcher<JIRABiDimensionalGridChartMacroParameter,
4545
JIRABiDimensionalGridChartJIRADataSource>
4646
{
47+
private static final String FILTER_ID = "filterId";
48+
4749
@Override
4850
public JIRAURLHelper.GadgetType getGadgetType()
4951
{
@@ -67,6 +69,12 @@ public List<NameValuePair> getCustomQueryParameters(JIRABiDimensionalGridChartMa
6769
@Override
6870
public NameValuePair handleFilterIdParameter(String filterIdValue)
6971
{
70-
return new BasicNameValuePair("filterId", computeFilterIdFormat(filterIdValue, true));
72+
return new BasicNameValuePair(FILTER_ID, computeFilterIdFormat(filterIdValue, true));
73+
}
74+
75+
@Override
76+
public NameValuePair handleQueryParameter(String queryValue)
77+
{
78+
return new BasicNameValuePair(FILTER_ID, "jql-" + queryValue);
7179
}
7280
}

0 commit comments

Comments
 (0)