fix: do not set setting with invalid params

Author: artemmufazalov

src/store/reducers/settings/api.ts

@@ -45,12 +45,10 @@ export const settingsApi = api.injectEndpoints({
                 name,
                 user,
                 value,
-            }: Partial<Omit<SetSingleSettingParams, 'value'>> & {value: unknown}) => {
+            }: Omit<SetSingleSettingParams, 'value'> & {value: unknown}) => {
                 try {
-                    if (!name || !user || !window.api?.metaSettings) {
-                        throw new Error(
-                            'Cannot set setting, no MetaSettings API or necessary params are missing',
-                        );
+                    if (!window.api?.metaSettings) {
+                        throw new Error('MetaSettings API is not available');
                     }
 
                     const data = await window.api.metaSettings.setSingleSetting({
@@ -71,10 +69,6 @@ export const settingsApi = api.injectEndpoints({
             async onQueryStarted(args, {dispatch, queryFulfilled}) {
                 const {name, user, value} = args;
 
-                if (!name) {
-                    return;
-                }
-
                 // Optimistically update existing cache entry
                 const patchResult = dispatch(
                     settingsApi.util.updateQueryData('getSingleSetting', {name, user}, () => value),

src/store/reducers/settings/useSetting.ts

@@ -1,5 +1,7 @@
 import React from 'react';
 
+import {isNil} from 'lodash';
+
 import {useSetting as useLSSetting} from '../../../utils/hooks';
 import {useTypedSelector} from '../../../utils/hooks/useTypedSelector';
 import {selectMetaUser} from '../authentication/authentication';
@@ -39,10 +41,10 @@ export function useSetting<T>(name?: string): {
             if (!name) {
                 return;
             }
-            if (window.api?.metaSettings) {
-                setMetaSetting({user, name, value});
-            } else {
+            if (isNil(window.api?.metaSettings)) {
                 saveSettingToLS(value);
+            } else if (window.api?.metaSettings && user) {
+                setMetaSetting({user, name, value});
             }
         },
         [user, name, setMetaSetting, saveSettingToLS],