added xslices.SortCopy

Author: asmyasnikov

internal/xslices/diff.go

@@ -9,8 +9,8 @@ func Diff[T any](from, to []T, cmp func(lhs, rhs T) int) (steady, added, dropped
 	added = make([]T, 0, len(to))
 	dropped = make([]T, 0, len(from))
 
-	to = Sort(to, cmp)
-	from = Sort(from, cmp)
+	to = SortCopy(to, cmp)
+	from = SortCopy(from, cmp)
 
 	for i, j := 0, 0; ; {
 		switch {

internal/xslices/sort.go

@@ -7,10 +7,14 @@ import (
 	"slices"
 )
 
-func Sort[T any](in []T, cmp func(lhs, rhs T) int) (out []T) {
+func SortCopy[T any](in []T, cmp func(lhs, rhs T) int) (out []T) {
 	out = Clone(in)
 
-	slices.SortFunc(out, cmp)
+	Sort(out, cmp)
 
 	return out
 }
+
+func Sort[T any](in []T, cmp func(lhs, rhs T) int) {
+	slices.SortFunc(in, cmp)
+}

internal/xslices/sort_go1.20.go

@@ -7,12 +7,18 @@ import (
 	"sort"
 )
 
-func Sort[T any](in []T, cmp func(lhs, rhs T) int) (out []T) {
+func SortCopy[T any](in []T, cmp func(lhs, rhs T) int) (out []T) {
 	out = Clone(in)
 
-	sort.Slice(out, func(i, j int) bool {
+	Sort(out, func(i, j int) bool {
 		return cmp(out[i], out[j]) < 0
 	})
 
 	return out
 }
+
+func Sort[T any](in []T, cmp func(lhs, rhs T) int) {
+	sort.Slice(in, func(i, j int) bool {
+		return cmp(in[i], in[j]) < 0
+	})
+}

internal/xslices/sort_test.go

@@ -6,9 +6,9 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
-func TestSort(t *testing.T) {
+func TestSortCopy(t *testing.T) {
 	src := []int{3, 2, 1}
-	dst := Sort(src, func(lhs, rhs int) int {
+	dst := SortCopy(src, func(lhs, rhs int) int {
 		return lhs - rhs
 	})
 	require.Equal(t, len(src), len(dst))

internal/xslices/transform.go

@@ -2,6 +2,7 @@ package xslices
 
 func Transform[T1, T2 any](in []T1, f func(t T1) T2) (out []T2) {
 	out = make([]T2, len(in))
+
 	for i, t := range in {
 		out[i] = f(t)
 	}