Skip to content

Commit cd27600

Browse files
authored
Merge pull request #526 from alex268/master
Allow super types for addChannelInitializer
2 parents b525fd9 + a7db2b0 commit cd27600

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

core/src/main/java/tech/ydb/core/grpc/GrpcTransportBuilder.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ public enum InitMode {
7272
private byte[] cert = null;
7373
private boolean useTLS = false;
7474
private ManagedChannelFactory.Builder channelFactoryBuilder = null;
75-
private final List<Consumer<ManagedChannelBuilder<?>>> channelInitializers = new ArrayList<>();
75+
private final List<Consumer<? super ManagedChannelBuilder<?>>> channelInitializers = new ArrayList<>();
7676
private Supplier<ScheduledExecutorService> schedulerFactory = YdbSchedulerFactory::createScheduler;
7777
private String localDc;
7878
private BalancingSettings balancingSettings;
@@ -187,7 +187,7 @@ public ManagedChannelFactory getManagedChannelFactory() {
187187
return channelFactoryBuilder.buildFactory(this);
188188
}
189189

190-
public List<Consumer<ManagedChannelBuilder<?>>> getChannelInitializers() {
190+
public List<Consumer<? super ManagedChannelBuilder<?>>> getChannelInitializers() {
191191
return this.channelInitializers;
192192
}
193193

@@ -209,7 +209,7 @@ public GrpcTransportBuilder withChannelFactoryBuilder(ManagedChannelFactory.Buil
209209
* @param ci custom ManagedChannelBuilder initializer
210210
* @return this
211211
*/
212-
public GrpcTransportBuilder addChannelInitializer(Consumer<ManagedChannelBuilder<?>> ci) {
212+
public GrpcTransportBuilder addChannelInitializer(Consumer<? super ManagedChannelBuilder<?>> ci) {
213213
channelInitializers.add(ci);
214214
return this;
215215
}

core/src/main/java/tech/ydb/core/impl/pool/NettyChannelFactory.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ public class NettyChannelFactory implements ManagedChannelFactory {
4141
private final long connectTimeoutMs;
4242
private final boolean useDefaultGrpcResolver;
4343
private final Long grpcKeepAliveTimeMillis;
44-
private final List<Consumer<ManagedChannelBuilder<?>>> initializers;
44+
private final List<Consumer<? super ManagedChannelBuilder<?>>> initializers;
4545

4646
private NettyChannelFactory(GrpcTransportBuilder builder) {
4747
this.database = builder.getDatabase();
@@ -101,7 +101,7 @@ public ManagedChannel newManagedChannel(String host, int port, String sslHostOve
101101
channelBuilder.disableRetry();
102102
}
103103

104-
for (Consumer<ManagedChannelBuilder<?>> initializer: initializers) {
104+
for (Consumer<? super ManagedChannelBuilder<?>> initializer: initializers) {
105105
initializer.accept(channelBuilder);
106106
}
107107

core/src/main/java/tech/ydb/core/impl/pool/ShadedNettyChannelFactory.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ public class ShadedNettyChannelFactory implements ManagedChannelFactory {
4141
private final long connectTimeoutMs;
4242
private final boolean useDefaultGrpcResolver;
4343
private final Long grpcKeepAliveTimeMillis;
44-
private final List<Consumer<ManagedChannelBuilder<?>>> initializers;
44+
private final List<Consumer<? super ManagedChannelBuilder<?>>> initializers;
4545

4646
public ShadedNettyChannelFactory(GrpcTransportBuilder builder) {
4747
this.database = builder.getDatabase();
@@ -101,7 +101,7 @@ public ManagedChannel newManagedChannel(String host, int port, String sslHostOve
101101
channelBuilder.disableRetry();
102102
}
103103

104-
for (Consumer<ManagedChannelBuilder<?>> initializer: initializers) {
104+
for (Consumer<? super ManagedChannelBuilder<?>> initializer: initializers) {
105105
initializer.accept(channelBuilder);
106106
}
107107

0 commit comments

Comments
 (0)