Skip to content

Conversation

@ZhandosKz
Copy link
Contributor

Q A
Is bugfix?
New feature? ✔️
Breaks BC?

Added the ability to customize the critical error message for the handleFallbackExceptionMessage method.
Previously, customizing this message required completely overriding the handleFallbackExceptionMessage
method. This PR introduces the ability to customize the error text by overriding just one method:
fallbackExceptionMessage

@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.15%. Comparing base (985ff9e) to head (a039999).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
framework/base/ErrorHandler.php 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #20681      +/-   ##
============================================
- Coverage     78.15%   78.15%   -0.01%     
- Complexity    11565    11566       +1     
============================================
  Files           376      376              
  Lines         30727    30729       +2     
============================================
  Hits          24016    24016              
- Misses         6711     6713       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright to me. Please add a line for changelog.

exit(1);
}

protected function fallbackExceptionMessage($exception)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a dock block missing here.
It's worth adding the @param annotation for $exception.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants