Skip to content

Commit e42fef7

Browse files
committed
Fix comparison between pointer and zero character constant.
Fix #44 See, libzbxsystemd.c: In function ‘SYSTEMD_UNIT_DISCOVERY’: libzbxsystemd.c:214:35: warning: comparison between pointer and zero character constant [-Wpointer-compare] 214 | if(NULL != filter || '\0' != filter) | ^~ libzbxsystemd.c:214:38: note: did you mean to dereference the pointer? 214 | if(NULL != filter || '\0' != filter) | Signed-off-by: Mario Trangoni <[email protected]>
1 parent c6c2c26 commit e42fef7

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/modules/systemd/libzbxsystemd.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ static int SYSTEMD_UNIT_DISCOVERY(AGENT_REQUEST *request, AGENT_RESULT *result)
211211
switch (i) {
212212
case 0:
213213
// filter by unit type
214-
if(NULL != filter || '\0' != filter)
214+
if(NULL != filter && '\0' != *filter)
215215
if(0 == systemd_cmptype(value.str, filter))
216216
goto next_unit;
217217

0 commit comments

Comments
 (0)