Skip to content

Conversation

@agnesLeroy
Copy link
Contributor

@agnesLeroy agnesLeroy commented Sep 9, 2025

  • remove use_carry from carry prop scratch which wasn't used
  • only allocate certain comparison LUTs in the EQ/NE case
  • some more minor fixes

@cla-bot cla-bot bot added the cla-signed label Sep 9, 2025
@agnesLeroy agnesLeroy marked this pull request as draft September 9, 2025 08:50
@agnesLeroy agnesLeroy force-pushed the al/post_hackathon_cleanup branch 2 times, most recently from 3597787 to c6da53e Compare September 10, 2025 12:31
@agnesLeroy agnesLeroy force-pushed the al/post_hackathon_cleanup branch from c6da53e to 04fa3ca Compare September 18, 2025 08:23
@agnesLeroy agnesLeroy marked this pull request as ready for review September 18, 2025 08:28
Copy link
Contributor

@andrei-stoian-zama andrei-stoian-zama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest some additional checks

@agnesLeroy agnesLeroy force-pushed the al/post_hackathon_cleanup branch from 04fa3ca to 20c79ac Compare September 18, 2025 11:55
Copy link
Contributor

@andrei-stoian-zama andrei-stoian-zama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great! I just have some minor aesthetic suggestions

Copy link
Contributor

@andrei-stoian-zama andrei-stoian-zama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!!

@agnesLeroy agnesLeroy merged commit fe6e81f into main Sep 18, 2025
120 checks passed
@agnesLeroy agnesLeroy deleted the al/post_hackathon_cleanup branch September 18, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants