Add validate_scopes_for_secure_parameter in Package#validate

Author: aishkan

lib/zendesk_apps_support/package.rb

@@ -36,9 +36,10 @@ def validate(options = {})
       skip_marketplace_translations = options.fetch(:skip_marketplace_translations, false)
       error_on_password_parameter = options.fetch(:error_on_password_parameter, false)
       validate_custom_objects_v2 = options.fetch(:validate_custom_objects_v2, false)
+      validate_scopes_for_secure_parameter = options.fetch(:validate_scopes_for_secure_parameter, false)
 
       errors = []
-      errors << Validations::Manifest.call(self, error_on_password_parameter: error_on_password_parameter)
+      errors << Validations::Manifest.call(self, error_on_password_parameter: error_on_password_parameter, validate_scopes_for_secure_parameter: validate_scopes_for_secure_parameter)
 
       if has_valid_manifest?(errors)
         errors << Validations::Marketplace.call(self) if marketplace

spec/package_spec.rb

@@ -455,18 +455,6 @@ def build_app_source_with_files(files)
       end
     end
 
-    context 'when error_on_password_parameter is true' do
-      let(:package) { ZendeskAppsSupport::Package.new('spec/fixtures/iframe_only_app') }
-
-      before do
-        allow(ZendeskAppsSupport::Validations::Manifest).to receive(:call)
-        package.validate!(marketplace: true, error_on_password_parameter: true)
-      end
-      it 'validate manifest and passes in the error_on_password_parameter correctly' do
-        expect(ZendeskAppsSupport::Validations::Manifest).to have_received(:call).with(package, {:error_on_password_parameter => true})
-      end
-    end
-
     context 'when validate_custom_objects_v2 is true' do
       let(:package) { ZendeskAppsSupport::Package.new('spec/fixtures/iframe_only_app') }
 
@@ -481,18 +469,25 @@ def build_app_source_with_files(files)
     end
 
     context 'when handling validation options' do
+      let(:package) { ZendeskAppsSupport::Package.new('spec/fixtures/iframe_only_app') }
+
       before do
         allow(ZendeskAppsSupport::Validations::Manifest).to receive(:call).and_return([])
         allow(ZendeskAppsSupport::Validations::Translations).to receive(:call)
         allow(ZendeskAppsSupport::Validations::Requirements).to receive(:call)
       end
 
+      it 'passes manifest validation options correctly' do
+        package.validate!(marketplace: true, error_on_password_parameter: true, validate_scopes_for_secure_parameter: true)
+        expect(ZendeskAppsSupport::Validations::Manifest).to have_received(:call).with(package, {:error_on_password_parameter => true, :validate_scopes_for_secure_parameter => true})
+      end
+
       it 'uses default values when called with empty options' do
         package.validate!
 
         expect(ZendeskAppsSupport::Validations::Manifest).to have_received(:call).with(
           package,
-          { error_on_password_parameter: false }
+          { error_on_password_parameter: false, validate_scopes_for_secure_parameter: false }
         )
         expect(ZendeskAppsSupport::Validations::Marketplace).to have_received(:call).with(package)
         expect(ZendeskAppsSupport::Validations::Translations).to have_received(:call).with(