Skip to content

Conversation

@duynguyenxa
Copy link
Member

@duynguyenxa duynguyenxa commented Oct 8, 2025

This commit is to support DRW accelerator for Renesas devices on Zephyr
If Zephyr is used the lv_draw_dave2d_cf_fb_get will get input format from device tree information
The macro to get the information is located at: https://github.com/zephyrproject-rtos/hal_renesas/pull/154/files#diff-de6e3e3502685f19aeefcf9bb9c021b19c0b4bfa5a8cbb49641c324f7e66f780R35

@faxe1008
Copy link
Collaborator

faxe1008 commented Oct 9, 2025

For CI purposes this fine, but we want the module to be 1:1 copy of upstream on the master branch. Therefore your change needs to be submitted upstream first. However this good to test the changes in zephyr repo as well.

@duynguyenxa
Copy link
Member Author

duynguyenxa commented Oct 14, 2025

hi @faxe1008 , it's seem that on the upstream the function is removed so this patched is no longer required, may I know when there will be update to Zephyr fork from lvgl upstream?

@faxe1008
Copy link
Collaborator

I plan to do it soonish, as v9.4 will be released tomorrow

@faxe1008
Copy link
Collaborator

@duynguyenxa took a bit longer then expected, but module PR was merged today.
Zephyr main repo PR will be merged probably until EOW:
zephyrproject-rtos/zephyr#97599

Copy link
Member

@uLipe uLipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my RA8D1 and works as intended.

Should we target the upstream with this PR too?

@faxe1008
Copy link
Collaborator

faxe1008 commented Dec 1, 2025

I looked into your patch as it is in my backlog and wanted to attempt to upstream a more generalized version. But it seems this change here depends on the HAL changes you proposed over here:
https://github.com/zephyrproject-rtos/hal_renesas/pull/154/files#diff-de6e3e3502685f19aeefcf9bb9c021b19c0b4bfa5a8cbb49641c324f7e66f780R35

But it hardcodes the pixel format used to be the one of chosen display. Since we now support multiple displays I kinda want this to work with any display. I will see if I can propose a more generalized solution.

@faxe1008
Copy link
Collaborator

faxe1008 commented Dec 1, 2025

Investigating a possible solution I saw that @uLipe already tackeled the issue with a general approach:
lvgl/lvgl@095e923

Can you confirm @duynguyenxa that this resolves the issue you were trying to solve with this patch? It would allow you to clean your HAL PR as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants