`zephyrbot` won't add reviewers/assignees to manifest PRs

[tomi-font]

Describe the bug

It adds the relevant labels but won't add anyone as reviewer/assignee.
This happens at least for the Mbed TLS and TF-M manifest projects, and has been for some time.

Example PRs:

• modules: Update trusted-firmware-m for picolibc #94367
• modules: mbedtls: Fix IAR __packed problem in mbedtls #90663

Both projects have defined collaborators/maintainers, e.g.:

zephyr/MAINTAINERS.yml

Lines 5851 to 5860 in 88de138

	"West project: trusted-firmware-m":
	status: maintained
	maintainers:
	- d3zd3z
	collaborators:
	- Vge0rge
	- wearyzen
	- valeriosetti
	- tomi-font
	- ithinuel

This is a rather important issue as it reduces the visiblity on PRs and may hinder/discourage contributors.

Regression

• This is a regression.

Steps to reproduce

No response

Relevant log output

Impact

Functional Limitation – Some features not working as expected, but system usable.

Environment

No response

Additional Context

No response

[fabiobaltieri]

@tomi-font you sure this used to work? The labels are form the manifest workflow but that does not know about maintainers, those are assigned by the set assignee script but IIRC that does not really know about west.yaml. Just saying I don't think it's a regression.

[tomi-font]

No I'm actually not sure, it's very possible you're right.
I've been assuming that the West project entries in the maintainers file would be for that when the revision is changed in west.yml.
So maybe this is more a feature request than a bug? Anyhow I still think it would be rather important to have.

[fabiobaltieri]

Ok, yeah it never did it, the intent was certainly to handle this case but I suppose it was never implemented. I actually added the code to assign PR on modules based on that information but we never managed to enable that either, just never figured out the permissions story.

Anyway I've unchecked the regression box but beside that yeah this would be a nice to have.

[tomi-font]

Yeah! also cc @kartben just in case