Add Aqara T1M ceiling light support (#4136)

Co-authored-by: TheJulianJES <[email protected]>

Author: evanjarrett

tests/test_xiaomi.py

@@ -50,6 +50,7 @@
     BatterySize,
 )
 from zhaquirks.xiaomi import (
+    AQARA,
     LUMI,
     XIAOMI_AQARA_ATTRIBUTE,
     XIAOMI_AQARA_ATTRIBUTE_E1,
@@ -78,6 +79,7 @@
     AqaraFeederAcn001,
     OppleCluster,
 )
+from zhaquirks.xiaomi.aqara.light_acn import AqaraLightT1M, LumiPowerOnStateMode
 import zhaquirks.xiaomi.aqara.magnet_ac01
 import zhaquirks.xiaomi.aqara.magnet_acn001
 import zhaquirks.xiaomi.aqara.magnet_agl02
@@ -2219,3 +2221,31 @@ def test_h1_wireless_remotes(zigpy_device_from_v2_quirk):
 
     assert MultistateInput.cluster_id in device.endpoints[2].in_clusters
     assert MultistateInput.cluster_id in device.endpoints[3].in_clusters
+
+
+@pytest.mark.parametrize("endpoint", [(1), (2)])
+def test_t1m_ceiling_light(zigpy_device_from_v2_quirk, endpoint):
+    """Test Aqara T1M ceiling light quirk adds missing endpoints."""
+
+    # create the device with 2 endpoints (one for each light on the T1M)
+    device = zigpy_device_from_v2_quirk(AQARA, "lumi.light.acn032", endpoint_ids=[1, 2])
+    assert AqaraLightT1M.cluster_id in device.endpoints[endpoint].in_clusters
+
+    aqara_cluster = device.endpoints[endpoint].opple_cluster
+    cluster_listener = ClusterListener(aqara_cluster)
+
+    aqara_cluster.update_attribute(AqaraLightT1M.AttributeDefs.power_on_state.id, 0x01)
+    assert len(cluster_listener.attribute_updates) == 1
+    assert (
+        cluster_listener.attribute_updates[0][0]
+        == AqaraLightT1M.AttributeDefs.power_on_state.id
+    )
+    assert cluster_listener.attribute_updates[0][1] == LumiPowerOnStateMode.LastState
+
+    aqara_cluster.update_attribute(AqaraLightT1M.AttributeDefs.power_on_state.id, 0x02)
+    assert len(cluster_listener.attribute_updates) == 2
+    assert (
+        cluster_listener.attribute_updates[1][0]
+        == AqaraLightT1M.AttributeDefs.power_on_state.id
+    )
+    assert cluster_listener.attribute_updates[1][1] == LumiPowerOnStateMode.Off

zhaquirks/xiaomi/__init__.py

@@ -51,6 +51,7 @@
     BatterySize,
 )
 
+AQARA = "Aqara"
 BATTERY_LEVEL = "battery_level"
 BATTERY_PERCENTAGE_REMAINING = 0x0021
 BATTERY_PERCENTAGE_REMAINING_ATTRIBUTE = "battery_percentage"

zhaquirks/xiaomi/aqara/light_acn.py

@@ -2,6 +2,7 @@
 
 from zigpy import types as t
 from zigpy.profiles import zgp, zha
+from zigpy.quirks.v2 import QuirkBuilder
 from zigpy.zcl.clusters.general import (
     Alarms,
     AnalogInput,
@@ -20,6 +21,7 @@
 from zigpy.zcl.clusters.homeautomation import ElectricalMeasurement
 from zigpy.zcl.clusters.lighting import Color
 from zigpy.zcl.clusters.smartenergy import Metering
+from zigpy.zcl.foundation import BaseAttributeDefs, DataTypeId, ZCLAttributeDef
 
 from zhaquirks.const import (
     DEVICE_TYPE,
@@ -30,13 +32,22 @@
     PROFILE_ID,
 )
 from zhaquirks.xiaomi import (
+    AQARA,
     LUMI,
     BasicCluster,
     XiaomiAqaraE1Cluster,
     XiaomiCustomDevice,
 )
 
 
+class LumiPowerOnStateMode(t.enum8):
+    """Power on state mode."""
+
+    On = 0x00
+    LastState = 0x01
+    Off = 0x02
+
+
 class OppleClusterLight(XiaomiAqaraE1Cluster):
     """Add Opple cluster for power outage memory attribute."""
 
@@ -45,6 +56,21 @@ class OppleClusterLight(XiaomiAqaraE1Cluster):
     }
 
 
+class AqaraLightT1M(XiaomiAqaraE1Cluster):
+    """Add power on state management for Lumi devices."""
+
+    class AttributeDefs(BaseAttributeDefs):
+        """Manufacturer specific attributes."""
+
+        power_on_state = ZCLAttributeDef(
+            id=0x0517,
+            type=LumiPowerOnStateMode,
+            zcl_type=DataTypeId.uint8,
+            access="rw",
+            is_manufacturer_specific=True,
+        )
+
+
 class LumiLightAcn003(XiaomiCustomDevice):
     """Quirk for Aqara ceiling light L1-350 also known as Xiaomi ZNXDD01LM.
 
@@ -200,3 +226,27 @@ class LumiLightAcn014(XiaomiCustomDevice):
             },
         }
     }
+
+
+(
+    QuirkBuilder(AQARA, "lumi.light.acn032")
+    .friendly_name(manufacturer="Aqara", model="Ceiling Light T1M")
+    .replaces(AqaraLightT1M)
+    .replaces(AqaraLightT1M, endpoint_id=2)
+    .enum(
+        AqaraLightT1M.AttributeDefs.power_on_state.name,
+        LumiPowerOnStateMode,
+        AqaraLightT1M.cluster_id,
+        translation_key="power_on_state",
+        fallback_name="Power on state",
+    )
+    .enum(
+        AqaraLightT1M.AttributeDefs.power_on_state.name,
+        LumiPowerOnStateMode,
+        AqaraLightT1M.cluster_id,
+        endpoint_id=2,
+        translation_key="power_on_state",
+        fallback_name="Power on state",
+    )
+    .add_to_registry()
+)