Skip to content

Conversation

@daric93
Copy link

@daric93 daric93 commented Nov 10, 2025

This PR introduces Valkey integration for the Redis-based vector store in GPTCache.
#673.

Key changes include:

Valkey compatibility:

Conditional SORTBY logic:

  • Adds runtime capability check before appending .sort_by("score") to queries.
  • Falls back gracefully when SORTBY is unsupported (avoids query errors).

No breaking changes:

  • Existing Redis functionality remains unchanged.
  • Valkey support is transparent to callers.

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: daric93
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot
Copy link
Collaborator

Welcome @daric93! It looks like this is your first PR to zilliztech/GPTCache 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants