[Android] java.lang.RuntimeException - Possible Race Condition

[K-Leon]

I've just observed this Crash in the wild - i could imagine that it could be some sort of Race Condition or maybe both - onError and onCompletion - is called at a certain condition.

Fatal Exception: java.lang.RuntimeException: Illegal callback invocation from native module. This callback type only permits a single invocation from native code.
       at com.facebook.react.bridge.CallbackImpl.invoke(CallbackImpl.java:32)
       at com.zmxv.RNSound.RNSoundModule$1.onCompletion(RNSoundModule.java:81)
       at android.media.MediaPlayer$EventHandler.handleMessage(MediaPlayer.java:2538)
       at android.os.Handler.dispatchMessage(Handler.java:102)
       at android.os.Looper.loop(Looper.java:135)
       at com.facebook.react.bridge.queue.MessageQueueThreadImpl$3.run(MessageQueueThreadImpl.java:196)
       at java.lang.Thread.run(Thread.java:818)

[benvium]

@K-Leon Interesting - if onError and onCompletion were both called this'd definitely happen. Not sure why that'd happen, but we could protect against it in the Java code

[benvium]

I made a PR that may fix this. I don't have a good test case though at the moment.

[K-Leon]

Wow.. this was fast! Thank you very much! I'll push this asap to production and let you know if i see this error again

[rohitgoyal]

Is this resolved?

[K-Leon]

I just checked Error logs and i've seen this one again - i have no idea how this can happen.

[henninghall]

I can confirm that this bug still exists even when using the fixes #107 and #87. Ideas: Could it possibly has something to to with not releasing resources after using them? Interferences with other media playing apps? Restarting sounds? Playing sounds with volume 0?

[ndbroadbent]

I think this could be similar to the race condition I fixed in #153.

It might need a fix similar to this: ivpusic/react-native-image-crop-picker#235

[ndbroadbent]

I've submitted a PR with this fix: #154

@henninghall and @K-Leon, please let me know if this fixes it for you.

[henrikra]

This is serious bug and needs to be fixed :(

[benvium]

@henrikra Does #154 fix this issue for you? If so I'll merge it now