content: Revise "unimplemented content" UX #1622
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Komyyy
force-pushed
the
unimplemented
branch
2 times, most recently
from
2ddabdb to
9b73e9a
Compare
Member
|
Thanks @Komyyy for sending this PR! Sorry we didn't reply sooner with any feedback. (At the time we were quite busy with the app's launch, but we could certainly have gotten back to it in the months thereafter.) As discussed at #194 (comment) , I've just closed the issue this is for. So I'll close this PR too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the UX for displaying "unimplemented content" errors.
Specifically, it changes the display from a long red inline code to a prominent modal with a spoiler-like appearance.
Additionally, the modal contains a clear explanation of the error and the HTML that caused the error.
resolves #194