Skip to content

msglist: Support viewing who reacted to a message #1700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

msglist: Support viewing who reacted to a message #1700

wants to merge 3 commits into from

Conversation

chrisbobbe
Copy link
Collaborator

@chrisbobbe chrisbobbe commented Jul 10, 2025 •
edited
Loading

Fixes #740.

Still TODO:

  • File a follow up for getting the view to live-update properly (turns out PerAccountStore doesn't notify listeners on reaction events)
  • Tests
  • Separate out some prep commits
  • center emojis horizontally when few?
  • don't show "see who reacted" button in message action sheet if there are no reactions

chrisbobbe added 3 commits July 9, 2025 17:44
@chrisbobbe
action_sheet: Choose "Close" and "Cancel" consistently for bottom sheets
b32b0b1 
This fixes the two inconsistencies flagged in discussion:
  https://chat.zulip.org/#narrow/channel/530-mobile-design/topic/bottom.20sheet.20.22Cancel.22.2F.22Close.22.20button/near/2216116

> I think it's reasonable to have both labels, but I think we should
> choose them differently than now:
>
> - "Cancel" when the sheet is about doing an action: [etc.]
>
> - "Close" when the sheet just presents information or nav options:
>   [etc.]
@chrisbobbe
icons: Add see_who_reacted, from Vlad on CZO
e2d95b4 
See Vlad's SVG on CZO:
  https://chat.zulip.org/#narrow/channel/530-mobile-design/topic/View.20Reactions.20ModalBottomSheet/near/2025350
@chrisbobbe
msglist: Support viewing who reacted to a message
27dd265 
Fixes zulip#740.
@chrisbobbe chrisbobbe requested a review from gnprice July 10, 2025 00:50
@chrisbobbe chrisbobbe added the integration review Added by maintainers when PR may be ready for integration label Jul 10, 2025
@chrisbobbe chrisbobbe mentioned this pull request Jul 10, 2025
Open
@gnprice
Copy link
Member

gnprice commented Jul 10, 2025

Thanks! I skimmed through this and I'm pretty confident it won't break any existing functionality. I also saw you demonstrate this running on your device, and it seemed to work well. So I plan to include this in today's upcoming release, without yet merging to main.

@gnprice gnprice mentioned this pull request Jul 10, 2025
Open
@sm-sayedi sm-sayedi mentioned this pull request Jul 15, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnprice gnprice Awaiting requested review from gnprice

Assignees

@gnprice gnprice

Labels
integration review Added by maintainers when PR may be ready for integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

See who left an emoji reaction
2 participants
@chrisbobbe @gnprice