wip: update compiler to use miden-vm v0.18 #681
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that midenc-hir-type is used by miden-assembly-syntax, and its types are re-exported there - it is necessary for compiler crates to depend on the same version as miden-assembly-syntax to allow for passing those types between APIs of the compiler, miden-assembly-syntax, and miden-mast-package. If we instead retained a direct path dependency on the source of midenc-hir-type, Cargo would see the dependencies as effectively different versions, and therefore make it impossible to pass types between those crates as they would not be considered the same anymore. Manual conversion would be possible, but undesirable. Since we plan to split out midenc-hir-type eventually anyway (or at the very least, do what this commit does and treat it as an entirely separate crate from the rest of the compiler), this change makes that transition easier, at the expense of being a bit confusing when making changes to midenc-hir-type that need to be propagated to crates.io first in order to meaningfully test the full compiler pipeline with those changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the necessary changes to migrate to the v0.18 release of the various VM crates we rely on.
NOTE: This cannot be merged until v0.18 is released and
miden-base,miden-client, andmiden-nodehave migrated (and ideally also been released, but we could also pin to a git ref likenexttemporarily if need be). That should be some time next week I believe. Until then, any of our integration tests that depend on those crates will fail to compile.The main things that change here are:
account_component_metadatafield ofmiden_mast_package::Package, and the addition of first-class custom section support (where the account component metadata is now stored).miden_assembly_syntax::ast::Instructionvariants related to MASM'spushinstruction, replacing them withPush(IntValue)andPushWord(WordValue)variants. This required changing a bunch of uses of the old variants in the codegen backend, which has been refactored a bit to avoid hardcoding whatInstructionvariant is used in all those places, instead centralizing it in the emitter.SyncHost/AsyncHosttraits of the processor