Add P2IDE note example #704
Conversation
partylikeits1983
added
the
examples
| inputs: vec![ | ||
| alice_account.id().prefix().as_felt(), | ||
| alice_account.id().suffix(), | ||
| timelock_height.into(), | ||
| reclaim_height.into(), |
There was a problem hiding this comment.
4 inputs to the note
examples/p2ide-note/src/lib.rs
Outdated
| let inputs = note::get_inputs(); | ||
| let target_account_id_prefix = inputs[0]; | ||
| let target_account_id_suffix = inputs[1]; | ||
| let timelock_height = inputs[2]; | ||
| let reclaim_height = inputs[3]; |
There was a problem hiding this comment.
Note consumption fails when more than 2 inputs. If timelock_height & reclaim_height are commented out, note consumption works.
examples/p2ide-note/src/lib.rs
Outdated
| // get block number | ||
| let block_number = tx::get_block_number(); | ||
|
|
||
| assert!(block_number >= timelock_height); |
There was a problem hiding this comment.
The reason for step 2 failure is this assert!. The timelock_height is 1000, but the test suite is bootstrapping the chain so the block_number should be low digits. If you set timelock_height to 1 this assert! is passing. After that the test fails at step 5.
There was a problem hiding this comment.
I wish this was the issue. I updated the code to demonstrate that this is not the issue. The issue is that if you try to initialize more than 2 variables from note inputs:
let inputs = note::get_inputs();
let target_account_id_prefix = inputs[0];
let target_account_id_suffix = inputs[1];
let timelock_height = inputs[2]; // fails when uncommentedThere was a problem hiding this comment.
Oh, this fails on step 5. In this case send_asset_to_account makes a note providing only 2 elements (account id) as note inputs. So there are only 2 elements in inputs.
| fn run(_arg: Word) { | ||
| let inputs = note::get_inputs(); | ||
| let target_account_id_prefix = inputs[0]; | ||
| let target_account_id_suffix = inputs[1]; | ||
|
|
||
| let timelock_height = inputs[2]; // fails when uncommented |
There was a problem hiding this comment.
fails when trying to initialize more than 2 inputs.
2 participants
This PR adds the P2IDE note as an example note.