Skip to content

common/hexutil: replace customized bit sizer with bit.Uintsize #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

common/hexutil: replace customized bit sizer with bit.Uintsize #185

wants to merge 1 commit into from

Conversation

zhedazijingang
Copy link

replace customized bit sizer with bit.Uintsize

Inspired by https://github.com/ethereum/go-ethereum/pulls?q=bit.Uintsize

@zhedazijingang
Copy link
Author

friendly ping~

@pkieltyka
Copy link
Member

Thanks for the PR. What’s the advantage?

@zhedazijingang
Copy link
Author

Thanks for the PR. What’s the advantage?

This change can omit the line const uintBits = 32 << (uint64(^uint(0)) >> 63) and use the built-in constant instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zhedazijingang @pkieltyka