Fix/fee option #530
Draft
Fix/fee option #530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* move package json deps * linting
…496) * session permissions utils, fee options handling, testing + bug fixes * fix comments * refactor improvements * export Session from @0xsequence/connect * use ExplicitSession type
* update deps, types and add modifySession * fix default fee options in connector * Update sequence packages --------- Co-authored-by: Tolgahan Arikan <[email protected]>
* remove dependency on ethers * replace hardcoded wordlist with one from viem
#527) * added includeFeeOptionPermissions to addExplicitSession * update dapp-client package * add value forwarder for native fee option
* add includeFeeOptionPermissions flag * remove console log * use getFeeTokens from dapp-client instead of relayer api * added GetFeeTokensResponse type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for fee option permissions and reduce api call
Ticket link: https://github.com/0xsequence/issue-tracker/issues/5946
API breaking changes:
Manual testing required:
Docs changes required:
Description
When creating permissions for fee options, "cumulative" should be false for the "to" address which is the relayer payment address, otherwise it will only allow paying once with the token.