Skip to content

Conversation

pasabanov
Copy link
Contributor

No description provided.

@complexspaces
Copy link
Member

I'm not sure there's a reason to do this. The generated bindings haven't needed updated in a while and there's no changes being made here either.

@pasabanov
Copy link
Contributor Author

Isn't a version update always a good idea?

@complexspaces
Copy link
Member

Not always, no. I generally try to be conservative with dep updates because fragmenting people's lockfiles is worse then using out-of-date code. In this case its not a dependency downstream users see but the generated Windows code hasn't needed updating so this is of similarly low priority/concern right now.

If you want to merge this, it needs to at least handle updates to the configuration syntax for the code generator, update the checked-in bindings, etc so that these don't become a disjoint problem N months from now when it needs to be ran again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants