WIP: Настройки прокси в первом приближении #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nixel2007
reviewed
Feb 28, 2020
| @@ -71,6 +74,12 @@ export class ServerDownloader { | |||
| this.installDir = installDir; | |||
| this.assetName = assetName; | |||
| this.token = token; | |||
|
|
|||
| const configuration = vscode.workspace.getConfiguration(LANGUAGE_1C_BSL_CONFIG); | |||
There was a problem hiding this comment.
по аналогии с token это лучше передавать из-вне
nixel2007
reviewed
Feb 28, 2020
| @@ -355,6 +360,7 @@ | |||
| "request": "^2.88.0", | |||
| "request-progress": "^3.0.0", | |||
| "request-promise-native": "^1.0.8", | |||
| "https-proxy-agent": "^5.0.0", | |||
|
@EvilBeaver не хочешь добить? |
|
А ноду в vscode обновили? Тут проблема в том, что я уже не работаю в той корп.сети в которой была наглухо закрытая прокся. И поэтому понять успех или неуспех - не смогу. Там кончилось дело тем, что в vscode была версия ноды, в которой внутри той сети вообще не работало хттп и прокси, даже в чистых JS скриптах. |
сейчас 12.14.1. Какая была на момент отправки пулл-реквеста уже не помню. :( |
nixel2007
force-pushed
the
develop
branch
2 times, most recently
from
28f3c05 to
59d1eb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
На данный момент победить прокси не удалось, но работать должно примерно так, как в PR