[Snyk] Security upgrade nodemailer from 6.4.6 to 7.0.11 #1197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-NODEMAILER-14157156
There was a problem hiding this comment.
Pull request overview
This is an automated Snyk security PR that upgrades nodemailer from ^6.4.1 to ^7.0.11 to fix a high-severity vulnerability (SNYK-JS-NODEMAILER-14157156: Uncontrolled Recursion). However, this is a major version upgrade with breaking changes that will cause the application to fail.
Key Issues:
- Critical: Nodemailer v7.x requires Node.js v18+, but the project uses Node.js v12.6.0
- The upgrade includes breaking API changes (callback deprecation, transport option changes)
- Potential compatibility issues with nodemailer-smime dependency
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "nested-property": "^0.0.7", | ||
| "node-schedule": "^1.3.2", | ||
| "nodemailer": "^6.4.1", | ||
| "nodemailer": "^7.0.11", |
There was a problem hiding this comment.
Nodemailer v7.x requires Node.js v18 or higher, but this project uses Node.js v12.6.0 (as specified in .node-version). This upgrade will break the application. You need to either:
- Upgrade Node.js to v18+ before upgrading nodemailer, or
- Stay on nodemailer v6.x and apply security patches
Additionally, nodemailer v7.x has breaking API changes:
- The callback pattern in
sendMail()is deprecated (see src/server/api/endpoints/i/update-email.ts:88-100) - Some transport options like
ignoreTLSmay have changed - The
nodemailer-smimedependency (v1.1.0) may not be compatible with nodemailer v7.x
Suggested change
| "nodemailer": "^7.0.11", | |
| "nodemailer": "^6.9.4", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-NODEMAILER-14157156
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.