-
-
Notifications
You must be signed in to change notification settings - Fork 1
[Snyk] Security upgrade systeminformation from 4.24.1 to 5.27.14 #1198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: twista
Are you sure you want to change the base?
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-SYSTEMINFORMATION-14459105
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR upgrades the systeminformation package from version 4.24.1 to 5.27.14 to fix a critical command injection vulnerability (SNYK-JS-SYSTEMINFORMATION-14459105) with a severity score of 853. This is a major version upgrade that may introduce breaking changes to the API.
Key changes:
- Security upgrade from systeminformation 4.x to 5.x addresses command injection vulnerability
- Major version bump indicates potential API breaking changes
- PR includes warning that yarn.lock failed to update
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "stylus-loader": "^3.0.2", | ||
| "summaly": "^2.3.1", | ||
| "systeminformation": "^4.16.0", | ||
| "systeminformation": "^5.27.14", |
Copilot
AI
Dec 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a major version upgrade from 4.x to 5.x which likely introduces breaking changes in the systeminformation API. The codebase uses the mem() method in two locations (src/daemons/server-stats.ts and src/misc/show-machine-info.ts) and accesses properties like 'active', 'total', and 'available'. Before merging, verify that these properties still exist and have the same meaning in version 5.x, as major version upgrades often change the data structure returned by API methods.
| "systeminformation": "^5.27.14", | |
| "systeminformation": "^4.34.23", |
| "stylus-loader": "^3.0.2", | ||
| "summaly": "^2.3.1", | ||
| "systeminformation": "^4.16.0", | ||
| "systeminformation": "^5.27.14", |
Copilot
AI
Dec 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the PR description, the yarn.lock file failed to update. This means the dependency resolution is incomplete and the project cannot be built or deployed until yarn.lock is properly updated. You must run 'yarn install' locally to generate a valid yarn.lock file and commit it before this PR can be safely merged.
| "stylus-loader": "^3.0.2", | ||
| "summaly": "^2.3.1", | ||
| "systeminformation": "^4.16.0", | ||
| "systeminformation": "^5.27.14", |
Copilot
AI
Dec 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The systeminformation library is used in server-stats.ts and show-machine-info.ts but there are no automated tests covering these modules. Since this is a major version upgrade with potential breaking changes, add integration tests to verify that the mem() method returns the expected data structure with the 'active', 'total', and 'available' properties before merging this security fix.
Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-SYSTEMINFORMATION-14459105
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Command Injection