Stop sending update_fee for mobile wallets
#3186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-bast
force-pushed
the
phoenix-no-update-fee
branch
2 times, most recently
from
a0a2685 to
7165ac7
Compare
t-bast
force-pushed
the
phoenix-no-update-fee
branch
from
7165ac7 to
1833eae
Compare
We stop sending `update_fee` and set the feerate to `1 sat/byte` for channels with mobile wallet users. This removes edge cases around `update_fee` handling in tricky cases (splicing, shutdown, etc) while still allowing channels to force-close thanks to package relay. Note that mobile wallets that don't have an on-chain wallet to use CPFP on the commit transaction may not be able to get their commit tx confirmed, but that was already the case before that change since the LSP decides the commit feerate. This will get better with v3 txs and https://delvingbitcoin.org/t/zero-fee-commitments-for-mobile-wallets/1453
t-bast
force-pushed
the
phoenix-no-update-fee
branch
from
1833eae to
3cfe30d
Compare
pm47
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We stop sending
update_feeand set the feerate to1 sat/bytefor channels with mobile wallet users. This removes edge cases aroundupdate_feehandling in tricky cases (splicing, shutdown, etc) while still allowing channels to force-close thanks to package relay.Note that mobile wallets that don't have an on-chain wallet to use CPFP on the commit transaction may not be able to get their commit tx confirmed, but that was already the case before that change since the LSP decides the commit feerate. This will get better with v3 txs and https://delvingbitcoin.org/t/zero-fee-commitments-for-mobile-wallets/1453