-
Notifications
You must be signed in to change notification settings - Fork 0
Taso rules #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lexu27
wants to merge
24
commits into
master
Choose a base branch
from
taso_rules
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Taso rules #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following changes/fixes/enhancements:
Support for non rank polymorphic tensor declaration using
rankPrecondition :: RClassIdentifier -> Int -> DSLContext (). Users can now also usenewSingletonRClassandnewSingletonRClassesto create RClasses with a fixed rank of 1. The bound inference algorithm sets upper and lower bounds for fixed rclasses equal to the number the users set.iotaandconcatTensorcallmarkSingletonunder the hood.printTitleprints with colors for whether verification succeds or fails.11/12 TASO operators are implemented now excluding
pool. The operators are desugared down to XLA operators in TASO.hs.Most operators from the TASO paper are verified within TensorRight (except for
pooland a few rules that either cannot be verified or hang). Onlymatmulandconvhave troublesome properties.Problematic Rules
Any convolution rule with SAME padding currently needs more than 15 seconds to verify so the rewrite rules time out. This is because of the complexity with dynamically calculating the proper padding configuration for SAME padding based on input and kernel maps.
convBaseCheckforces output feature classes to not be in theinputRClasses. Since we are comparing toxthis might cause trouble during verification as the output feature rClass is no longer the same as the input.Checks
ormolu, a Haskell Formatter? Runormolu --mode inplace $(git ls-files '*.hs')to format all files in the project.hie.yamlusing the commandgen-hie > hie.yaml?stack test?Not all TASO tests pass using stack test.