Fix cmplog collection in ASAN builds #3387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `__libafl_targets_cmplog_routines_len` and `__libafl_targets_cmplog_routines_extended_len`, `area_is_valid` was called with `CMPLOG_RTN_LEN` as length instead of the length passed as argument. In ASAN instrumented builds, this leads to an early exit since ASAN would detect the region as poisoned anytime the argument's actual length is less than `CMPLOG_RTN_LEN`. Fix this issue by passing the len argument instead of `CMPLOG_RTN_LEN`.
|
didn't you already do this? |
|
Indeed, but I mistakenly linked my personal email to the commit when I should link my google email as per company policy. Is there another way to modify the committer email? |
|
no i don't think we can modify it unless force push to main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In
__libafl_targets_cmplog_routines_lenand__libafl_targets_cmplog_routines_extended_len,area_is_validwas called withCMPLOG_RTN_LENas length instead of the length passed as argument.In ASAN instrumented builds, this leads to an early exit since ASAN would detect the region as poisoned anytime the argument's actual length is less than
CMPLOG_RTN_LEN.Fix this issue by passing the len argument instead of
CMPLOG_RTN_LEN.