Skip to content

Conversation

@A9isha
Copy link
Collaborator

@A9isha A9isha commented Nov 7, 2025

Description

Adding support for building from local copies of tunix, vllm and pathways. And also fixing the # of tokens generated by evaluate(). Also update the run commands documentation.

Tests

Built a docker image from local copies and run llama3.1-70b on v5p-64

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@A9isha A9isha force-pushed the anisha-fix-trainrl branch 2 times, most recently from 941b239 to 4b9e44f Compare November 10, 2025 19:56
@A9isha A9isha force-pushed the anisha-fix-trainrl branch 7 times, most recently from d020385 to 9f266a6 Compare November 12, 2025 22:26
Copy link
Collaborator

@richjames0 richjames0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@A9isha A9isha force-pushed the anisha-fix-trainrl branch 2 times, most recently from 097512f to 89f72df Compare November 12, 2025 23:45
@A9isha A9isha force-pushed the anisha-fix-trainrl branch from 89f72df to de6cd69 Compare November 13, 2025 17:28
@A9isha A9isha force-pushed the anisha-fix-trainrl branch from de6cd69 to be4576a Compare November 13, 2025 17:29
@copybara-service copybara-service bot merged commit 81eca03 into main Nov 13, 2025
58 checks passed
@copybara-service copybara-service bot deleted the anisha-fix-trainrl branch November 13, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants