Rename read_timeout to timeout in Orbax handler.
#116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_813431195
branch
from
28470c0 to
9bfe49b
Compare
copybara-service
bot
changed the title
read_timeout to timeout in Orbax handler.
copybara-service
bot
force-pushed
the
test_813431195
branch
from
9bfe49b to
130cded
Compare
This change renames the `read_timeout` parameter to a more general `timeout` in `CloudPathwaysArrayHandler` and `register_pathways_handlers`. A default timeout of 1 hour is also added within the handler's constructor. PiperOrigin-RevId: 813833165
copybara-service
bot
force-pushed
the
test_813431195
branch
from
130cded to
d83f050
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
read_timeouttotimeoutin Orbax handler.This change renames the
read_timeoutparameter to a more generaltimeoutinCloudPathwaysArrayHandlerandregister_pathways_handlers. A default timeout of 1 hour is also added within the handler's constructor.