Use kueue manifest from CT url #557
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Piotr Pawłowski <[email protected]>
Signed-off-by: Piotr Pawłowski <[email protected]>
pawloch00
requested review from
Obliviour,
44past4,
sharabiani,
BluValor,
gcie and
RoshaniN
as code owners
Signed-off-by: Piotr Pawłowski <[email protected]>
sharabiani
reviewed
Jul 25, 2025
src/xpk/core/kueue.py
Outdated
| # new_memory_limit = ( | ||
| # f'{max(math.ceil(int(out) * MEMORY_SIZE_PER_VM), MIN_MEMORY_LIMIT_SIZE)}Mi' | ||
| # ) | ||
| kueue_controller_manager_yaml = 'https://raw.githubusercontent.com/GoogleCloudPlatform/cluster-toolkit/refs/tags/v1.57.1/modules/management/kubectl-apply/manifests/kueue-v0.12.2.yaml' |
There was a problem hiding this comment.
Kueue and CT versions can be variables
Signed-off-by: Piotr Pawłowski <[email protected]>
|
@SujeethJinesh we are removing string with patch to kueue manager config. If you want to change limits in kueue config please come up with another way to do this. The way it is now is error prone and creates two sources of same kueue config. |
Signed-off-by: Piotr Pawłowski <[email protected]>
…rcomputer/xpk into ppawl-fix-kueue-manifest
Signed-off-by: Piotr Pawłowski <[email protected]>
sharabiani
approved these changes
Jul 25, 2025
scaliby
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes / Features
Testing / Documentation
Testing details.