Skip to content

Conversation

@wdconinc
Copy link
Contributor

@wdconinc wdconinc commented Dec 31, 2025

This PR updates the install location for the python package to support free-threaded pythons. See also AIDASoft/podio#911, key4hep/EDM4hep#469.

BEGINRELEASENOTES

  • cmake: install python files into free-threaded python3.??t/site-packages prefix

ENDRELEASENOTES

Copilot AI review requested due to automatic review settings December 31, 2025 01:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Python package installation path configuration to support free-threaded Python builds (PEP 703), which introduce an ABI suffix (e.g., 't') to the site-packages directory name (python3.14t/site-packages instead of python3.14/site-packages).

Key changes:

  • Replace hardcoded Python install path construction with extraction from Python_SITEARCH
  • Add regex-based extraction to handle ABI suffixes automatically
  • Implement fallback mechanism for compatibility with standard Python installations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Dec 31, 2025

Test Results

   18 files     18 suites   6h 38m 2s ⏱️
  372 tests   372 ✅ 0 💤 0 ❌
3 278 runs  3 278 ✅ 0 💤 0 ❌

Results for commit afeb0e4.

♻️ This comment has been updated with latest results.

Copy link
Member

@andresailer andresailer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@andresailer andresailer merged commit 284dd40 into AIDASoft:master Jan 5, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants