Make project REUSE compliant + add pre-commit hooks #413
Conversation
puneetmatharu
changed the title
puneetmatharu
force-pushed
the
add-reuse-compliance
branch
from
b5172b7 to
04c6fd7
Compare
|
N.B. I only need one reviewer (first-come-first-served basis); just so happens that both are likely familiar with making such changes. |
puneetmatharu
force-pushed
the
add-reuse-compliance
branch
from
04c6fd7 to
5150ae9
Compare
nSircombe
left a comment
nSircombe
left a comment
There was a problem hiding this comment.
I've had a read through, and posted a few comments / questions.
...rks/pytorch-aarch64/examples/gen_ai_utils/quant_configs/aarch64_cpu_channelwise.json.license
Outdated
Show resolved
Hide resolved
puneetmatharu
force-pushed
the
add-reuse-compliance
branch
3 times, most recently
from
348df01 to
06eb981
Compare
nSircombe
left a comment
nSircombe
left a comment
There was a problem hiding this comment.
There are a lot of year changes. Many of which I understand, but not all.
I think this is going to be very difficult to review that these in this form.
Do you think we could have a summary table in the PR for all the files having year changes, from what to what and why?
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # SPDX-FileCopyrightText: Copyright 2021-2025 Arm Limited and affiliates. |
There was a problem hiding this comment.
this one appears to have gained the year 2024?
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # SPDX-FileCopyrightText: Copyright 2021, 2022, 2024, 2025 Arm Limited and affiliates. |
There was a problem hiding this comment.
This appears to have lost the year 2023
There was a problem hiding this comment.
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # SPDX-FileCopyrightText: Copyright 2021, 2023, 2025 Arm Limited and affiliates. |
There was a problem hiding this comment.
This has lost the year 2022 - is this one that shouldn't carry the year 2022?
There was a problem hiding this comment.
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # SPDX-FileCopyrightText: Copyright 2021, 2024, 2025 Arm Limited and affiliates. |
There was a problem hiding this comment.
Patched! Change in 2024 was a rename.
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # SPDX-FileCopyrightText: Copyright 2022, 2024, 2025 Arm Limited and affiliates. |
There was a problem hiding this comment.
Should this have 2022? I didn't think it was that old.
There was a problem hiding this comment.
Well spotted -- removed! (GitHub thought the file, incorrectly, came from get-bazel.sh)
puneetmatharu
force-pushed
the
add-reuse-compliance
branch
from
06eb981 to
34a4fb3
Compare
|
@nSircombe have updated the PR body. Full table of copyright changes and reasoning where appropriate |
2 participants
Summary
LICENSES/directory as required by thereusetool..licensefile.2024-2025) get split up by the reuse tool (e.g.2024, 2025); this is a known feature that seemingly can't be avoided.Table of changes
Any additions of 2025 come from adding the current year's date. Although the code isn't merged in 2025, the changes are made in 2025.
N.B. the table below is cropped horizontally in the GitHub UI; if you scroll to the right, you'll be able to see an additional "Notes" section with additional helpful info.
C.D. = creation date
.github/workflows/pytorch.yml.github/workflows/tensorflow.ymlLICENSES/Apache-2.0.txtML-Frameworks/pytorch-aarch64/examples/executor/model.pyML-Frameworks/pytorch-aarch64/examples/gen_ai_utils/quant_configs/aarch64_cpu_channelwise.json.licenseML-Frameworks/pytorch-aarch64/examples/gen_ai_utils/quant_configs/aarch64_cpu_groupwise.json.licenseML-Frameworks/pytorch-aarch64/examples/utils/common.pyML-Frameworks/pytorch-aarch64/examples/utils/image.pyML-Frameworks/pytorch-aarch64/examples/utils/label.pyML-Frameworks/pytorch-aarch64/examples/utils/nlp.pyML-Frameworks/pytorch-aarch64/examples/utils/vision_parser.pyML-Frameworks/pytorch-aarch64/examples/.gitignoreML-Frameworks/pytorch-aarch64/examples/answer_questions.pyML-Frameworks/pytorch-aarch64/examples/classify_image.pyML-Frameworks/pytorch-aarch64/examples/detect_objects.pyML-Frameworks/pytorch-aarch64/examples/llama_vision_instruct.pyML-Frameworks/pytorch-aarch64/examples/openimages-mlperf.json.licenseML-Frameworks/pytorch-aarch64/examples/quantized_linear.pyML-Frameworks/pytorch-aarch64/examples/README.mdML-Frameworks/pytorch-aarch64/examples/resnet_v1-50.ymlML-Frameworks/pytorch-aarch64/examples/run_unit_tests.shML-Frameworks/pytorch-aarch64/examples/ssd_resnet34.pyML-Frameworks/pytorch-aarch64/examples/ssd_resnet34.ymlML-Frameworks/pytorch-aarch64/examples/test-examples.shML-Frameworks/pytorch-aarch64/examples/transformers_llm_text_gen.pyML-Frameworks/pytorch-aarch64/scripts/build-mlcommons.shML-Frameworks/pytorch-aarch64/scripts/download-dataset.shML-Frameworks/pytorch-aarch64/scripts/download-model.shML-Frameworks/pytorch-aarch64/.dockerignoreget-bazel.sh(obviously not).ML-Frameworks/pytorch-aarch64/.gitignoreget-bazel.sh(obviously not).ML-Frameworks/pytorch-aarch64/bash_profileML-Frameworks/pytorch-aarch64/build-torch-ao-wheel.shML-Frameworks/pytorch-aarch64/build-wheel.shML-Frameworks/pytorch-aarch64/build.shML-Frameworks/pytorch-aarch64/bump-sources.shML-Frameworks/pytorch-aarch64/CHANGELOG.mdML-Frameworks/pytorch-aarch64/cpu_info.shML-Frameworks/pytorch-aarch64/DockerfileML-Frameworks/pytorch-aarch64/dockerize.shget-bazel.sh(obviously not).ML-Frameworks/pytorch-aarch64/get-source.shML-Frameworks/pytorch-aarch64/README.mdML-Frameworks/pytorch-aarch64/requirements.txtML-Frameworks/pytorch-aarch64/welcome.txt.licensewelcome.txtHistoryML-Frameworks/tensorflow-aarch64/examples/executor/model.pyML-Frameworks/tensorflow-aarch64/examples/utils/common.pyML-Frameworks/tensorflow-aarch64/examples/utils/image.pyML-Frameworks/tensorflow-aarch64/examples/utils/label.pyML-Frameworks/tensorflow-aarch64/examples/utils/nlp.pyML-Frameworks/tensorflow-aarch64/examples/utils/nlp_parser.pyML-Frameworks/tensorflow-aarch64/examples/utils/vision_parser.pyparser.pywhich was created in 2021.ML-Frameworks/tensorflow-aarch64/examples/answer_questions.pyML-Frameworks/tensorflow-aarch64/examples/classify_image.pyML-Frameworks/tensorflow-aarch64/examples/detect_objects.pyML-Frameworks/tensorflow-aarch64/examples/README.mdML-Frameworks/tensorflow-aarch64/examples/resnet_v1-50.ymlML-Frameworks/tensorflow-aarch64/examples/run_unit_tests.shML-Frameworks/tensorflow-aarch64/examples/ssd_resnet34.ymlML-Frameworks/tensorflow-aarch64/examples/test_examples.shML-Frameworks/tensorflow-aarch64/.dockerignoreML-Frameworks/tensorflow-aarch64/.gitignoreML-Frameworks/tensorflow-aarch64/bash_profileML-Frameworks/tensorflow-aarch64/build-wheel.shbuild-tensorflow-addons.sh; created in 2022.ML-Frameworks/tensorflow-aarch64/build.shML-Frameworks/tensorflow-aarch64/bump-sources.shML-Frameworks/tensorflow-aarch64/CHANGELOG.mdML-Frameworks/tensorflow-aarch64/DockerfileML-Frameworks/tensorflow-aarch64/dockerize.shML-Frameworks/tensorflow-aarch64/get-source.shML-Frameworks/tensorflow-aarch64/README.mdML-Frameworks/tensorflow-aarch64/requirements.txtML-Frameworks/tensorflow-aarch64/welcome.txt.licenseML-Frameworks/pytorch-aarch64/utils/helper.shML-Frameworks/utils/git-utils.sh.gitignore.pre-commit-config.yamlCONTRIBUTING.mdREADME.mdSECURITY.md