Skip to content

Split the SAL into two modules to eliminate several circular dependencies #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Split the SAL into two modules to eliminate several circular dependencies #18

wants to merge 2 commits into from

Conversation

bremoran
Copy link
Contributor

This split means that the notional dependency tree from sockets looks like:

sockets
┣─ sal-td
┃ ┣─ sal
┃ ┗─ sal-stack-lwip
┃   ┣─ sal

(pruned for readability)

Since sal does not have a targetDependency on sal-stack-lwip, there is no circular dependency between the two. This means that a new sal can be published without breaking sal-stack-lwip.

@autopulated @0xc0170 @bogdanm

@bremoran
Split the SAL into two modules
1892e80 
One module contains the SAL and the other contains target dependencies.
This eliminates definition-based circular dependencies from the SAL.
@bremoran
Change dependencies to test dependencies.
8f876b0
@bremoran
Copy link
Contributor Author

(This is a prototype and not expected to be merged for beta)

Don't panic, @bogdanm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bremoran