-
Notifications
You must be signed in to change notification settings - Fork 1
[Design] 편지 등록(보내기) 입력 페이지 분할 및 UX 라이팅 수정 #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
해결이 잘 안 되네요..! 내일 다시 한번 해보겠습니다 |
Member
|
나는 오히려 분리를 하는게 더 좋을 것 같아! 나중에 수정할 부분 생기면 유지보수하기가 더 좋을 듯 싶어서! |
Member
|
store 무난해서 좋은듯!! |
Contributor
Author
오호 이것도 맞는 말이네..! 화면이 계속 바뀔 수 있는 걸 생각 못했어. 좋아 그럼 기존대로 페이지는 따로따로 하고 공통으로 쓰이는 컴포넌트들만 분리하도록 할게😀 |
🎉 Deploy Previewhttps://lettering-clrby398v-yyypearls-projects.vercel.app |
hyo-4
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
연관 이슈
close #130
개요
편지 등록(보내기) 입력 페이지 분할 및 UX 라이팅 수정
✅ 작업 내용
letter→store로 라우터명 변경🖥 구현 결과
20250123_213506.mp4
리뷰 요구사항
store가 더 나을 것 같아서 라우터를 분리했는데 괜찮은가요? store가 전역 저장소에서도 쓰이는 이름이기는 해서 다른 걸로 바꾸는 게 좋은가 싶기도 했습니다!📝 기타 사항