Skip to content

Conversation

@lukasmatta
Copy link
Collaborator

@lukasmatta lukasmatta commented May 6, 2024

Once fix for angular/angular-cli#27590 is published (should be the next patch version as the fix PR is already merged) we will need to update @angular/angular-cli package.

Note that CpsDivider was removed as it does not support SSR (it is accessing document directly - _dividerColor -> getCSSColor -> isValidCSSColor -> document.createElement on colors-utils.ts:13)

@lukasmatta lukasmatta linked an issue May 6, 2024 that may be closed by this pull request
@fateeand
Copy link
Contributor

fateeand commented May 7, 2024

So basically isValidCSSColor is a fundamental library function, we need to reimplement it using color-name to check css named colors and regular expressions for verifying other formats.

@lukasmatta
Copy link
Collaborator Author

I think it should be enough to just not use global document object and use Document from DI instead

@fateeand
Copy link
Contributor

fateeand commented May 7, 2024

I think it should be enough to just not use global document object and use Document from DI instead

This will also work, but we need to pass it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for SSG to improve performance

3 participants