-
Notifications
You must be signed in to change notification settings - Fork 648
nVIDIA CUDA R3D #4260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
nVIDIA CUDA R3D #4260
Conversation
Signed-off-by: Peter Kovář <[email protected]>
Signed-off-by: Peter Kovář <[email protected]>
|
//Flags used by the linker during the creation of shared libraries |
Signed-off-by: Peter Kovář <[email protected]>
Signed-off-by: Peter Kovář <[email protected]>
Signed-off-by: Peter Kovář <[email protected]>
|
There is still needed to add:
|
Signed-off-by: Peter Kovář <[email protected]>
Signed-off-by: Peter Kovář <[email protected]>
Signed-off-by: Peter Kovář <[email protected]>
src/r3d.imageio/r3dinput.cpp
Outdated
| #define GPU | ||
| #define CUDA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm concerned about setting these unconditionally.
Does every system that would have R3DSDK always have the CUDA SDK available?
We already have a CMake variable called OIIO_USE_CUDA to enable CUDA at build time, and when that is enabled and the CUDA SDK is found, it will define the C++ preprocessor symbol OIIO_USE_CUDA, so you should use that rather than making new symbols.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, indeed. These definitions do belong to the build configuration settings. Will modify ASAP.
Within the R3DSDK there are four options: CPU only decoding, nVIDIA CUDA, OpenCL and 🍏Metal.
Signed-off-by: Peter Kovář <[email protected]>
Description
This is intended to add support of R3D CUDA based decoder, which is much faster than R3D CPU only decoder.
RED One clips are handled by the CPU.
Tests
Checklist:
(adding new test cases if necessary).
corresponding Python bindings (and if altering ImageBufAlgo functions, also
exposed the new functionality as oiiotool options).
already run clang-format before submitting, I definitely will look at the CI
test that runs clang-format and fix anything that it highlights as being
nonconforming.