-
Notifications
You must be signed in to change notification settings - Fork 643
cmake script to auto download and install the openjpeg dependency #4911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
cmake script to auto download and install the openjpeg dependency #4911
Conversation
Signed-off-by: grdanny <[email protected]>
src/cmake/build_OpenJPEG.cmake
Outdated
set_cache (OpenJPEG_BUILD_VERSION 2.5.4 "OpenJPEG version for local builds") | ||
set (OpenJPEG_GIT_REPOSITORY "https://github.com/uclouvain/openjpeg.git") | ||
set (OpenJPEG_GIT_TAG "v${OpenJPEG_BUILD_VERSION}") | ||
set_cache (OpenJPEG_BUILD_SHARED_LIBS OFF #${LOCAL_BUILD_SHARED_LIBS_DEFAULT} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was there a reason you forced OFF here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact, this may be why the Windows test is failing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was "learning" a bit from the build_PNG.cmake (and a few others that had it off).
let me try to set it from the LOCAL_BUILD_SHARED_LIBS_DEFAULT
I think this is correct, but in ci.yml, in the "all local builds" job, you'll want to remove the setting of env variable OPENJPEG_VERSION=v2.5.4 because that will trigger the external script build_OpenJPEG.bash before the build. You don't want that, in this case you want to be sure you're forcing the autobuild one. |
…it gets auto downloaded using the name cmake script Signed-off-by: grdanny <[email protected]>
…LD_SHARED_LIBS_DEFAULT Signed-off-by: grdanny <[email protected]>
Signed-off-by: grdanny <[email protected]>
Signed-off-by: grdanny <[email protected]>
Signed-off-by: grdanny <[email protected]>
Signed-off-by: grdanny <[email protected]>
Description
sub task of : #4387
for sep 2025 dev days.
Adding a autobuild cmake file for openjpeg.
Matching the latest version like in the yet unmerged:
#4910
Tests
I built it locally - I can see it's downloading the files from github and building them.
I can run the tests.
Checklist:
need to update the documentation, for example if this is a bug fix that
doesn't change the API.)
(adding new test cases if necessary).
corresponding Python bindings (and if altering ImageBufAlgo functions, also
exposed the new functionality as oiiotool options).
already run clang-format before submitting, I definitely will look at the CI
test that runs clang-format and fix anything that it highlights as being
nonconforming.