Skip to content

Conversation

servantftransperfect
Copy link
Contributor

Upgrading fmt dependency to 12.0.0.

Current fmt version is not compatible with Clang 21.1.2 (Maybe older too)

Signed-off-by: Fabien Servant <[email protected]>
@linux-foundation-easycla
Copy link

CLA Not Signed

@lgritz
Copy link
Collaborator

lgritz commented Sep 28, 2025

I am not opposed to raising the auto-build version of fmt. There is another PR #4910 in review that updates several auto-build versions (which does not include fmt, but I think that is a mere oversight and not purposeful intent).

But this change is failing on Windows, so there's probably something else still needing adjustment for that platform.

Can you please explain more about how fmt 10.2 was failing against clang 21.1? Can you maybe reproduce some of the error log here so we can see?

Since auto-build is just used when a dependency is not found externally, if it's true that certain (moderately recent, even) versions of fmt don't work with the latest compilers, I feel like we should detect this case and warn about it with a clear explanation, even when not doing auto-build.

@lgritz lgritz added the build / testing / port / CI Affecting the build system, tests, platform support, porting, or continuous integration. label Oct 11, 2025
@lgritz
Copy link
Collaborator

lgritz commented Oct 11, 2025

Hi, @servantftransperfect, any comments about this?

@servantftransperfect
Copy link
Contributor Author

I'm sorry, i am not able to reproduce it. It currently compiles out of the box (?). Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build / testing / port / CI Affecting the build system, tests, platform support, porting, or continuous integration.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants