-
Couldn't load subscription status.
- Fork 309
Update codecov action to v5 #1961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Joshua Minor <[email protected]>
|
See also: #1838 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1961 +/- ##
==========================================
+ Coverage 85.10% 85.11% +0.01%
==========================================
Files 181 181
Lines 12768 12768
Branches 1206 1206
==========================================
+ Hits 10866 10868 +2
+ Misses 1719 1717 -2
Partials 183 183
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Signed-off-by: Joshua Minor <[email protected]>
|
Reading a bit more about how this works, I suspect that the coverage for PRs is working okay, but the coverage upload after a PR lands in the main branch is not. That's why codecov is able to compare this PR's head but not to main (since it hasn't received an upload from main since 80 commits ago). Maybe? If I look at a recent codecov task on the main branch, I see some suspicious warnings: https://github.com/AcademySoftwareFoundation/OpenTimelineIO/actions/runs/18852215970/job/53791315602 Warning 1: Warning 2: Warning 3: Despite these warnings, it says "Process Upload complete" at the end: Of all those, the one I'm most suspicious of is the last one. Why is it uploading to an URL with |
|
The verbose logs from this PR look slightly better: I still see Warning 1: I do not see Warning 2 (something about DOCTYPE). I still see Warning 3 (maybe trying to detect macOS?) The ending looks more like I expected: Notably it says |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When using third party GitHub Actions, it is recommended to pin to a specific version using the commit SHA of the corresponding commit.
So instead of:
uses: codecov/codecov-action@v5
it is preferred to use:
uses: codecov/codecov-action@5a1091511ad55cbe89839c7260b706298ca349f7 # v5.5.1
where you can find out the commit SHA on the release page for the action
|
Also there may be codecov (possibly expired?) secrets at the AcademySoftwareFoundation GitHub organization level that are getting in the way of what you are trying to do? I'd suggest opening a LF helpdesk ticket to ask what Codecov secrets may be installed at the org level? |
|
A more recent PR now also says says Also, when I navigate here: https://app.codecov.io/github/AcademySoftwareFoundation/OpenTimelineIO now Codecov's dashboard shows "Source: latest commit 829a913" from a few hours ago, where it used to show the commit from a year ago. However, the most recent PR (also from a few hours ago) still shows the "80 commits behind" stale base: #1964 Maybe that was generated before 829a913 landed? Let's see what the next PR reports. It might be fixed now? 🙏 |
Thanks for the suggestion @jfpanisset. Once we get it working properly, we can pin it (and our other actions). |
|
I rebased this PR onto latest main and the coverage report looks to be fixed!! |
|
Nice, It definitely looks better. Should we check this in and test it with a PR that has some C++ changes? I did notice this warning is still there, but I don't know how important it is: |
|
So my conclusion is that the problem was related to the Codecov token stored in this repo's secrets. Updating that token fixed the problem. The changes in this PR are helpful/harmless, but were not needed to fix the issue. Specifically it updates to v5 of the action and moves the coverage report to a newer version of Python. |
OTIO's code coverage reports have been stuck in a stale state for a while now. Pull requests report coverage based on a commit from Apr 14, 2024 instead of the current main. For example:
In an attempt to get this fixed I have just re-read the instructions https://github.com/codecov/codecov-action, re-entered the repo's CODECOV token in the "secrets" settings area, and in this PR, updated the codecov action to v5.
Let's see if that helps...