Remove fallbacks and add explicit tag family parameter in AprilTag detection #543
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses review feedback on #542 to remove defensive fallbacks and verify pose detection math.
Changes
Removed fallbacks:
pupil_apriltags(raises ImportError if missing)load_camera_intrinsics()propagates FileNotFoundErrordetect_apriltag_pupil()raises FileNotFoundError for missing imagespd.Timestamp.now()fallback in JSON exportExplicit tag family:
--tag-familyCLI argument (default:tag36h11)Math verification:
Cross-checked against pupil-apriltags docs — implementation is correct:
[fx, fy, cx, cy]from intrinsic matrixR.from_matrix(pose_R).as_euler('xyz', degrees=True)✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.