CI: separate fastlane and build code...WIP #114
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to e0c5193 in 13 seconds
More details
- Looked at
36lines of code in3files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. Makefile:213
- Draft comment:
Ensure that the system where this Makefile will be used has the newer version of ImageMagick installed that supports themagickcommand. - Reason this comment was not posted:
Confidence changes required:33%
The change fromconverttomagickin the Makefile is likely an update to use ImageMagick's newer command syntax. This is generally a good practice asmagickis the recommended way to invoke commands in newer versions of ImageMagick, providing better consistency and additional features. However, it's important to ensure that the system where this Makefile will be used has the newer version of ImageMagick installed that supports themagickcommand.
Workflow ID: wflow_RzFOkZ4lSgIM7rt8
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
0xbrayo
force-pushed
the
master
branch
2 times, most recently
from
e055897 to
d54aed0
Compare
|
WIP. Separating the fastlane code from the build code |
0xbrayo
changed the title
|
@ellipsis-dev review |
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to d54aed0 in 1.0 minute and 23.142585999999994 seconds
More details
- Looked at
267lines of code in3files - Skipped
0files when reviewing. - Skipped posting
5drafted comments based on config settings.
1. .github/workflows/build-only.yml:20
- Draft comment:
Consider using the same Ubuntu version for all jobs within this workflow to ensure consistency. For example, you could update all jobs to useubuntu-20.04:
runs-on: ubuntu-20.04
- Reason this comment was not posted:
Confidence of 40% on close inspection, compared to threshold of 50%.
2. .github/workflows/build-only.yml:22
- Draft comment:
It's recommended to use the same version ofactions/checkoutacross all steps. Consider updating all instances to usev3for consistency and to benefit from the latest features and fixes:
- uses: actions/checkout@v3
- Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
3. .github/workflows/build-only.yml:152
- Draft comment:
The actionactions/cache/restore@v3does not exist. You should useactions/cache@v3with the appropriaterestore-keysfor restoring cache. Here's the corrected usage:
- uses: actions/cache@v3
- Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
4. .github/workflows/build-only.yml:210
- Draft comment:
The actionactions/download-artifact@v3does not exist. You should useactions/download-artifact@v2for downloading artifacts. Here's the corrected usage:
- uses: actions/download-artifact@v2
- Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
5. .github/workflows/build-only.yml:197
- Draft comment:
The actionactions/upload-artifact@v3does not exist. You should useactions/upload-artifact@v2for uploading artifacts. Here's the corrected usage:
- uses: actions/upload-artifact@v2
- Reason this comment was not posted:
Confidence of 50% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_PIM8TfWyRK0FoIzz
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| # Build in release mode if on a tag/release (longer build times) | ||
| echo "RELEASE=${{ startsWith(github.ref_name, 'v') }}" >> $GITHUB_ENV | ||
|
|
||
| - name: Set up JDK |
There was a problem hiding this comment.
Consider upgrading to the latest version of actions/setup-java to benefit from new features and improvements:
Suggested change
| - name: Set up JDK | |
| uses: actions/setup-java@v3 |
0xbrayo
force-pushed
the
master
branch
7 times, most recently
from
10fd8e7 to
854877e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Separated Fastlane and build code in CI, updated image conversion command, and added shell syntax highlighting in documentation.
Key points:
.github/workflows/build-only.ymlto separate Fastlane and build code in CI.Makefileto usemagickinstead ofconvertfor image conversion.ExternalStorageConfigurationManagerin.idea/misc.xml.shsyntax highlighting to code block inREADME.md.Generated with ❤️ by ellipsis.dev