feat/push2 web #770
feat/push2 web #770
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@NikIvv please merge |
|
Deployed to https://msg-adamant-pr-770.surge.sh 🚀 |
|
@dvelikiy @bludnic @S-FrontendDev |
| manifest: manifest, | ||
| manifestFilename: 'manifest.json', | ||
| workbox: { | ||
| globPatterns: ['**/*.{js,css,html,ico,png,svg,wasm}'], |
There was a problem hiding this comment.
Why caching of static files was removed?
| </options-wrapper> | ||
| </template> | ||
|
|
||
| <script> |
There was a problem hiding this comment.
Lets convert Options.vue into Composition API and TypeScript
There was a problem hiding this comment.
@S-FrontendDev @skranee
Didn't we do it yet in other pr?
| const firebaseConfig = { | ||
| apiKey: 'AIzaSyDgtB_hqwL1SS_YMYepRMmXYhmc7154wmU', | ||
| authDomain: 'adamant-messenger.firebaseapp.com', | ||
| databaseURL: 'https://adamant-messenger.firebaseio.com', | ||
| projectId: 'adamant-messenger', | ||
| storageBucket: 'adamant-messenger.appspot.com', | ||
| messagingSenderId: '987518845753', | ||
| appId: '1:987518845753:web:6585b11ca36bac4c251ee8' | ||
| } |
There was a problem hiding this comment.
We use same config in the app and in the Service Worker. Let's move the const into another place and import it.
| watch(myPK, (newVal, oldVal) => { | ||
| if (newVal && !oldVal) { | ||
| const channel = new BroadcastChannel('adm_notifications') | ||
| channel.postMessage({ isCheckPK: true }) | ||
| channel.onmessage = async (event) => { | ||
| const data = event.data | ||
| if (data && data.isNoPrivateKey) { | ||
| const privateKey = newVal | ||
| if (privateKey) channel.postMessage({ privateKey }) | ||
| } | ||
| } |
There was a problem hiding this comment.
Seems a little over engineering. Did you try just watching the value of store.state.passphrase from Vuex?
watch(() => store.state.passphrase, () => {
channel.postMessage(passphrase)
})Note: You can retrieve the privateKey and publicKey from passphrase.
|
Is this pr outdated and a duplicate of feat: add push notifications for web and android #802? |
4 participants
No description provided.