fix: changes BTS transaction status on rejected in chat when node validation fails #857
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Deployed to https://msg-adamant-pr-857.surge.sh 🚀 |
Linhead
force-pushed
the
bug/reject-by-dust-amount-not-working
branch
from
1c54c5f to
12a439b
Compare
| return (failureCount: number): boolean => { | ||
| return (failureCount: number, error: any): boolean => { | ||
| // Don't retry BTC transactions on 404 (dust amount rejections) | ||
| if (crypto === 'BTC' && error?.response?.status === 404) { |
There was a problem hiding this comment.
404 status is normal. Is it possible to check dust response?
There was a problem hiding this comment.
And i think we need to do it in src/hooks/queries/transaction/useBtcTransactionQuery.ts file
Linhead
force-pushed
the
bug/reject-by-dust-amount-not-working
branch
from
0d75e1b to
273bd60
Compare
Co-authored-by: skranee <[email protected]>
| retry: (failureCount: number): boolean => { | ||
| // Don't retry dust amount BTC transactions | ||
| const dustedIds = store.state.btc.dustedTransactionsIds || [] | ||
| if (dustedIds.length > 0 && dustedIds.includes(unref(transactionId))) { |
There was a problem hiding this comment.
dustedIds.length > 0 is excessive
| ) | ||
| context.commit('dustedTransactionsIds', signedTransaction.txid) | ||
| } | ||
| context.commit('transactions', [{ hash: signedTransaction.txid, status: 'REJECTED' }]) |
There was a problem hiding this comment.
May be it's better not to use dustedTransactionsIds but something like
context.commit('transactions', [{ hash: signedTransaction.txid, status: 'REJECTED', isDust: true }])
There was a problem hiding this comment.
It was my first idea. But I paid attention that transactions from store show only on wallet page. On chat page list of transactions are fetching by API call. That's why I need to check each transaction from API response if it was rejected by dust amount.
There was a problem hiding this comment.
I see, thanks.
@S-FrontendDev Please check if it's the optimal solution.
There was a problem hiding this comment.
On chat page list of transactions are fetching by API call
Do we still store transaction info locally?
May be we can mark this tx as isDust and amend this checking function accordingly.
There was a problem hiding this comment.
@adamantmm
We discussed with @S-FrontendDev and decided to do this fix as part of task that already implements a proper transaction status synchronization system without workarounds - https://trello.com/c/S29m39O1/759-coin-tx-status-chore-fix-verify-update-coin-tx-sending-algorithm
I've created a new PR for this fix - #866
Co-authored-by: Izar Konti <[email protected]>
Linhead
force-pushed
the
bug/reject-by-dust-amount-not-working
branch
from
149baca to
1efdacf
Compare
|
Successfully tore down https://msg-adamant-pr-857.surge.sh 🥲 |
Fixes illustration of status for BTC and BTC based coins transactions which are rejected due to dust amount on chat page