Skip to content

feat: remove kly #859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: dev
Choose a base branch
from
Open

feat: remove kly #859

wants to merge 12 commits into from

Conversation

@S-FrontendDev
Copy link
Member

@S-FrontendDev S-FrontendDev commented Sep 3, 2025 •
edited
Loading

Description

  • Removed support for KLY (Klayr) from the codebase.
  • Updated the wallets script.
  • Replaced lodash dependency with lodash-es.
  • Cleaned up related modules, actions, and imports (kly-base, kly-base-actions.js, etc.).
  • Resolved merge conflicts in scripts/wallets.mjs and related files.

Related issue

Closes #

Breaking changes

  • Yes — removal of KLY is a breaking change.
  • Users who previously relied on KLY wallets or transactions will no longer have access to this functionality.

How to test

  1. Build and run the app, ensure there are no missing imports or errors related to KLY.
  2. Verify wallet functionality (creation, balance, transactions) for other currencies (e.g., ADM) works as expected.
  3. Run the wallets script to confirm correct behavior without KLY.
  4. Confirm that the switch from lodash to lodash-es does not break existing functionality.
  5. Check that no UI elements or references to KLY remain in the app.

Notes for reviewers

  • Double-check for leftover KLY dependencies or unused imports.
  • Ensure that removed code did not affect unrelated modules.
  • Pay attention to tests — confirm that they were updated/removed where KLY was involved.
  • Review bundle size and tree-shaking impact from migrating to lodash-es.
  • Consider the impact on user data if any KLY wallets existed previously.

@vercel
Copy link

vercel bot commented Sep 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
adamant-im Ready Ready Preview Comment Sep 22, 2025 0:23am

@S-FrontendDev S-FrontendDev marked this pull request as ready for review September 22, 2025 12:12
@S-FrontendDev S-FrontendDev requested a review from a team as a code owner September 22, 2025 12:12
@S-FrontendDev
Merge remote-tracking branch 'origin/dev' into feat/remove-kly
ebf115a 
# Conflicts:
#	scripts/wallets.mjs
#	src/store/modules/kly-base/kly-base-actions.js
@S-FrontendDev
chore: lodash -> lodash-es
1e43619
@github-actions
Copy link

Deployed to https://msg-adamant-pr-859.surge.sh 🚀

@S-FrontendDev S-FrontendDev linked an issue Sep 22, 2025 that may be closed by this pull request
[Task] Remove Klayr (KLY) support in full #874
Open
6 tasks
@S-FrontendDev S-FrontendDev requested review from a team and graycraft September 23, 2025 15:57
@dev-adamant-im dev-adamant-im added APIs API design, endpoints, and integrations Blockchain Related to blockchain functionality, consensus, and ledger mechanics Composite task Large or complex task that consists of multiple subtask JavaScript Frontend or backend code in JavaScript labels Oct 7, 2025
@dev-adamant-im dev-adamant-im added this to the v4.11.0 milestone Oct 7, 2025
@dev-adamant-im dev-adamant-im removed this from the v4.11.0 milestone Oct 7, 2025
dev-adamant-im
dev-adamant-im requested changes Oct 7, 2025
View reviewed changes
Copy link
Member

@dev-adamant-im dev-adamant-im left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@S-FrontendDev

Enter a new account.
Check dev console, probably ReferenceError: Cannot access 'B' before initialization caused by these changes.

image

@S-FrontendDev
Copy link
Member Author

@dev-adamant-im i can't repeat it. Where did you get it? What staging?

@dev-adamant-im
Copy link
Member

dev-adamant-im commented Oct 7, 2025 •
edited
Loading

@S-FrontendDev

Log in test account, wait for chats, then log out.
https://msg-adamant-pr-859.surge.sh/

Production https://adm.im doesn't have these errors.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dev-adamant-im dev-adamant-im dev-adamant-im requested changes

@Linhead Linhead Linhead approved these changes

@graycraft graycraft Awaiting requested review from graycraft

Requested changes must be addressed to merge this pull request.

Assignees

@S-FrontendDev S-FrontendDev

Labels

APIs API design, endpoints, and integrations Blockchain Related to blockchain functionality, consensus, and ledger mechanics Composite task Large or complex task that consists of multiple subtask JavaScript Frontend or backend code in JavaScript

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Task] Remove Klayr (KLY) support in full

3 participants

@S-FrontendDev @dev-adamant-im @Linhead