Skip to content

fix: fix bug with no refreshing date in chat on visibillity event #863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

fix: fix bug with no refreshing date in chat on visibillity event #863

wants to merge 3 commits into from

Conversation

Linhead
Copy link
Collaborator

@Linhead Linhead commented Sep 12, 2025 •
edited by adamantmm
Loading

Fixes #862

Fix: Dates in chats not refreshing when day changes while app is in background

Problem
When user opens a chat late at night (e.g., 23:55) and messages display "Today", then switches to another tab/app, and returns after midnight (e.g., 00:05), the dates still incorrectly show "Today" instead of "Yesterday". The dates only refresh when opening another chat and coming back.

Solution

  • Added reactive dateRefreshKey that triggers component re-render on visibility change
  • Used existing Visibility.change handler to update the key when app becomes visible
  • Applied :key attribute to component for force re-render
  • Utilized existing maintainScrollPosition() method to preserve scroll position during re-render

Test instructions

  1. Change the system time to 23:55 or any other time close to midnight.
  2. Send any message in any chat.
  3. Verify that the message time in the chat is displayed as Today.
  4. Minimize the tab or the browser.
  5. After midnight (according to the system clock), return to the tab:
    • The sent message should now display the date as Yesterday.

@Linhead Linhead requested a review from a team as a code owner September 12, 2025 15:02
@vercel Vercel
Copy link

vercel bot commented Sep 12, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
adamant-im Ready Ready Preview Comment Sep 24, 2025 8:47am

@Linhead
Copy link
Collaborator Author

Linhead commented Sep 12, 2025 •
edited
Loading

https://trello.com/c/YPIhxrKv/827-bug-dates-in-chats-are-not-refreshing

@Linhead Linhead mentioned this pull request Sep 12, 2025
Open
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 12, 2025 •
edited
Loading

Deployed to https://msg-adamant-pr-863.surge.sh 🚀

@Linhead Linhead force-pushed the bug/dates-in-chats-are-not-refreshing branch from f496cf9 to 078039e Compare September 12, 2025 15:12
@Linhead Linhead linked an issue Sep 15, 2025 that may be closed by this pull request
[Bug] Dates in chats are not refreshing #862
Open
@adamantmm adamantmm assigned adamantmm and Linhead and unassigned adamantmm Sep 28, 2025
@adamantmm adamantmm added bug Something isn't working JavaScript Frontend or backend code in JavaScript UX/UI User interface and experience improvements labels Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamantmm adamantmm adamantmm approved these changes

@S-FrontendDev S-FrontendDev S-FrontendDev approved these changes

Assignees

@Linhead Linhead

Labels
bug Something isn't working JavaScript Frontend or backend code in JavaScript UX/UI User interface and experience improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Dates in chats are not refreshing
3 participants
@Linhead @adamantmm @S-FrontendDev