Cache matching endpoints in context #565
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
bitterpanda63
approved these changes
Mar 28, 2025
timokoessler
changed the title
![aikido-pr-checks[bot]](https://avatars.githubusercontent.com/in/898896?s=60&v=4){kind=small}
| } | ||
| const endpoints = matchEndpoints(context, this.nonGraphQLEndpoints); | ||
| // Cache the endpoints to avoid re-running the matchEndpoints function | ||
| updateContext(context, "cachedMatchingEndpoints", endpoints); |
There was a problem hiding this comment.
Function modifies input parameter 'context' by caching endpoints, creating unexpected side effects. More info
|
|
||
| getEndpoints(context: LimitedContext) { | ||
| return matchEndpoints(context, this.nonGraphQLEndpoints); | ||
| getEndpoints(context: Context): Endpoint[] { |
There was a problem hiding this comment.
Function mixes endpoint matching logic with caching infrastructure concerns. More info
| context.cache.delete(key); | ||
| } | ||
|
|
||
| // Delete cacheMatchingEndpoints if method, url, or route changes |
There was a problem hiding this comment.
Comment restates obvious code mechanics without explaining why cache invalidation is needed. More info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.