Skip to content

Adds typing to context where important for new multi-value headers, and streamlines header setting & getting #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

Adds typing to context where important for new multi-value headers, and streamlines header setting & getting #421

wants to merge 22 commits into from

Conversation

bitterpanda63
Copy link
Member

This update streamlines the context initialization process for WSGI and ASGI environments by:

  • Decoupling context creation from attribute setting.
  • Introducing WSGIContext and ASGIContext data classes to encapsulate parsed request data.
  • Adding type hints for improved code clarity and maintainability.
  • Adding a get_header function to the Context class for simplified header access.

These changes improve the modularity and testability of the context handling logic.

@bitterpanda63
Make context a dataclass with typing
8606591
@bitterpanda63
Revert "Make context a dataclass with typing"
5e80426 
This reverts commit 8606591.
@bitterpanda63
Context: add typing
340efba
@bitterpanda63
Create get_header function on context
bc2b134
@bitterpanda63
asgi: now returns ASGIContext
a784679
@bitterpanda63
WSGI: now returns WSGIContext
f9fe2ec
@bitterpanda63
Add typing to parse_cookies
e8d972e 
A
@bitterpanda63
Refactors context initialization for WSGI/ASGI
516364e 
Changes context initialization to utilize dedicated
parsing functions (parse_wsgi_environ, parse_asgi_scope)
for WSGI and ASGI requests.

This improves code organization and maintainability by
decoupling context attribute assignment from the main
Context class, and promotes code reuse.

Updates tests to reflect the change in header structure.
@bitterpanda63
Fix flask test cases
1834a2b
@bitterpanda63
get_ip_from_request: make capable of using headers
94ff879
@bitterpanda63
Create new headers store helper class
cd9f79a
@bitterpanda63
ASGI use new headers helper class
0331e85
@bitterpanda63
WSGI use new headers helper class
8b6e0c1
@bitterpanda63
context: use new headers helper class
6f30d95
@bitterpanda63
get_ip_from_request use new Headers class
3a62e36
@bitterpanda63
asgi also return headers type
99129db
@bitterpanda63
Fix test cases for get_ip_form_request_test.py
01e6c55
@bitterpanda63
rename get_ip_form_request to get_ip_from_request
aa31af9
@bitterpanda63
Fix import in headers.py
57662c2
@bitterpanda63 bitterpanda63 changed the title Refactors context handling and data extraction Adds typing to context where important for new multi-value headers, and streamlines header setting & getting Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bitterpanda63