Skip to content

Conversation

@mogeta
Copy link

@mogeta mogeta commented Feb 12, 2020

I have a little trouble that pinch area go to offscreen when device is landscape.
This problem is the difference between touch pos and minitouch

This is experimental pull request.
I know _touch_point_by_orientation is desired private method.

I am very helped by this tool
I hope you find something useful.
Thanks.

@adolli
Copy link
Member

adolli commented Mar 14, 2020

Thanks for your suggestion. How many brands of device have you tested on? the method _touch_point_by_orientation I am not pretty sure whether there're compatibility issues that vary across different android versions and device brands.

@adolli adolli requested a review from rockywhisper March 14, 2020 02:23
@adolli
Copy link
Member

adolli commented Mar 14, 2020

@rockywhisper would u please help me review this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants