refactor: decouple chunking disabling from file size #535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RSM upload steps are messy and hard to read, mainly because of the encryption metadata. By moving the instantiation to the data key and aad, we can separate the upload stages clearly.
Given that there are at least 3 objects uploaded per segment, and it could fail at any stage, the plugin should guard that the chances for orphan objects is minimal.
jeqo
force-pushed
the
jeqo/flag-chunking-disabled
branch
2 times, most recently
from
477d487 to
abc7c8f
Compare
Chunking is defined by original chunk size, not original content size. This PR removed the scenario where these two sizes are conflated (e.g. passing original size zero to disable chunking, etc.).
jeqo
force-pushed
the
jeqo/flag-chunking-disabled
branch
from
abc7c8f to
5726bc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chunking is defined by original chunk size, not original content size.
This PR removed the scenario where these two sizes are conflated (e.g. passing original size zero to disable chunking, etc.).
Depends on #531, see last commit for changes on this PR